Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for country of Serbia #1385

Merged
merged 7 commits into from
Oct 20, 2024
Merged

Adding support for country of Serbia #1385

merged 7 commits into from
Oct 20, 2024

Conversation

stalker314314
Copy link
Contributor

As per discussion at https://community.openstreetmap.org/t/dodavanje-na-welcome-osm-be/114304 we are requesting adding of Serbia here. OsmCha.id is left empty.

Only "non-conventional" thing is addition of two scripts of same language - Serbian Cyrillic and Serbian Latin. I didn't see any other language here using templates with different script, so I was not quite sure about directory name - does it relate to ISO 639 or is it just for display. In KDE/Gnome/Linux world, it is usually sr@latin or sr-latin, but I kept it here in the spirit of OSM name tag name:sr-Latn. Let me know what is preferred, so I can change it accordingly.

@stalker314314
Copy link
Contributor Author

Hi, @jbelien , friendly ping to take a look when you find time!:)

@jbelien jbelien added the region Add a new region label Sep 11, 2024
@jbelien
Copy link
Member

jbelien commented Oct 20, 2024

Only "non-conventional" thing is addition of two scripts of same language - Serbian Cyrillic and Serbian Latin. I didn't see any other language here using templates with different script, so I was not quite sure about directory name - does it relate to ISO 639 or is it just for display. In KDE/Gnome/Linux world, it is usually sr@latin or sr-latin, but I kept it here in the spirit of OSM name tag name:sr-Latn. Let me know what is preferred, so I can change it accordingly.

Symfony is based on https://icu.unicode.org/ and I think the correct code will be sr_Latn. I've made the necessary change.

@jbelien jbelien enabled auto-merge (squash) October 20, 2024 18:48
@jbelien jbelien disabled auto-merge October 20, 2024 18:51
@jbelien jbelien merged commit ca6e81d into osmbe:2.x Oct 20, 2024
9 checks passed
@stalker314314
Copy link
Contributor Author

Thanks! BTW, glad to see welcome.osm.be is alive and kickin'!:)

@stalker314314
Copy link
Contributor Author

@jbelien I noticed small bug, not sure where it lies. When I am on welcome message page, I cannot see latin message:
slika

If I click second language, I have URL with locale=sr_Latn&template=default.md loaded, but I still see cyrillic version of template. Like https://github.com/osmbe/osm-welcome-tool/blob/2.x/templates/messages/serbia/sr_Latn/default.md is not loading? I don't see anything in console, but I don't think this is frontend problem.

Side question: both labels are saying "Default (Serbian)", any way to change that to "Default (Serbian cyr)" and "Default (Serbian lat)" or something similar?

@jbelien
Copy link
Member

jbelien commented Oct 22, 2024

I've opened an new issue ( #1464 ), I'll investigate 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
region Add a new region
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants